fix: Adds scaling function to _readTwap #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #7267: Aggor deploy by August 2nd. |
jar-o
force-pushed
the
sc-7267-aggor-scale-patch
branch
2 times, most recently
from
27a080e to
67151b8
Compare
hexonaut
approved these changes
Jul 30, 2024
There was a problem hiding this comment.
Fix looks good, but would like to see a test specifically added that would have failed under the old setup. IE it would have explicitly, incorrectly picked the lower one always even if the high oracle is reporting something way off.
Also, these are code changes and need to be re-audited.
hexonaut
approved these changes
Jul 30, 2024
jar-o
force-pushed
the
sc-7267-aggor-scale-patch
branch
from
395f72c to
b80a638
Compare
jar-o
force-pushed
the
sc-7267-aggor-scale-patch
branch
from
b80a638 to
8ee9488
Compare
jar-o
changed the title
jar-o
force-pushed
the
sc-7267-aggor-scale-patch
branch
from
8ee9488 to
54087c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
_readTwap()function was not performing the proper scaling on the values it received from Uniswap.Aggoruses 8 decimals, and all sources, Chronicles, Chainlink, and Uniswap must conform from their defaults (which all vary) to match. Scaling is a pretty simple and normal pattern in Solidity, and we are employing it elsewhere in Aggor. It simply got missed/lost on the_readTwap()function.